Move plugin_init for verify cmd #9102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin_init calls api_init which will intialize all the global hooks needed for lifecycle and other plugins. Without doing this those hook objects are empty so if a plugin (such as lua) makes a call to add a lifecycle hook on remapinit, this will crash since they haven't been initialized
Member
Author
|
[approve ci] |
randall
approved these changes
Sep 23, 2022
zwoop
pushed a commit
that referenced
this pull request
Oct 4, 2022
plugin_init calls api_init which will intialize all the global hooks needed for lifecycle and other plugins. Without doing this those hook objects are empty so if a plugin (such as lua) makes a call to add a lifecycle hook on remapinit, this will crash since they haven't been initialized (cherry picked from commit 7c6d19c)
Contributor
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog s3_auth: Fix parsing of virtual_host (apache#9103) s3_auth: accept longer config lines (apache#9090) Add a proxy.config.http.per_server.connection.max test (apache#9097) Move plugin_init for verify cmd (apache#9102) Fix unused-but-set-variable warnings by llvm-15 (apache#9106) Fix compile error with llvm-15 (apache#9105) Fix expected sha1sum for the Proxy Verifier binary (apache#9112) Updating AuTest to use Proxy Verifier v2.4.2 (apache#9110)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugin_init calls api_init which will intialize all the global hooks needed for lifecycle and other plugins. Without doing this those hook objects are empty so if a plugin (such as lua) makes a call to add a lifecycle hook on remapinit, this will crash since they haven't been initialized. This occurs during the urlRewriteVerify step of verification where it tries to load plugins or at least initialize them, these will crash